On Fri, Jun 14, 2024 at 08:34:32AM -0400, Jeff Layton wrote: > This all looks pretty reasonable except for the last two patches. > Probably, they should be squashed together since there is no caller of > ->return_delegation until the last one. There is also nothing > describing the changes there, and I think it could use some explanation > (though I think I get what you're doing). > > Finally, I suppose we need to look at implementing support delstid in > knfsd as well. I'll open a new feature request for that the linux-nfs > project on github. I don't think there ever was a formal rule, but having a feature like this that affects all of the core nfs code without beeing able to test it against knfsd seems a bit dangerous indeed.
