Re: [PATCH v3 5/5] nfsd: new netlink ops to get/set server pool_mode

[Jakub Kicinski <kuba@xxxxxxxxxx>]

On Thu, 13 Jun 2024 14:34:34 -0400 Jeff Layton wrote:
> +	err = nla_put_string(skb, NFSD_A_POOL_MODE_MODE, buf) ||
> +	      nla_put_u32(skb, NFSD_A_POOL_MODE_NPOOLS, nfsd_nrpools(net));

bitwise or?

Other option would be to move sunrpc_get_pool_mode() before allocation
that way all error codes past allocations are EMSGSIZE and life is
simpler.