On Tue, May 28, 2024 at 03:23:39PM +0000, Daniel Gomez wrote: > I have the same patch for shmem and large folios tree. That was the last piece > needed for getting better performance results. However, it is also needed to > support folios in the write_begin() and write_end() callbacks. I don't think it's *needed*. It's nice! But clearly not necessary since Christoph made nfs work without doing that. > In order to avoid > making them local to shmem, how should we do the transition to folios in these > 2 callbacks? I was looking into aops->read_folio approach but what do you think? See the v2 of buffer_write_operations that I just posted. I was waiting for feedback from Christoph on the revised method for passing fsdata around, but I may as well just post a v2 and see what happens.
