On 5/9/24 9:31 AM, Jeff Layton wrote:
On Fri, 2024-03-08 at 13:02 -0500, trondmy@xxxxxxxxx wrote:From: Trond Myklebust <trond.myklebust@xxxxxxxxxxxxxxx> When creating a listener socket to be handed to /proc/fs/nfsd/portlist, we currently limit the number of backlogged connections to 64. Since that value was chosen in 2006, the scale at which data centres operate has changed significantly. Given a modern server with many thousands of clients, a limit of 64 connections can create bottlenecks, particularly at at boot time. Let's use the POSIX-sanctioned maximum value of SOMAXCONN. Signed-off-by: Trond Myklebust <trond.myklebust@xxxxxxxxxxxxxxx> --- v2: Use SOMAXCONN instead of a value of -1. utils/nfsd/nfssvc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/utils/nfsd/nfssvc.c b/utils/nfsd/nfssvc.c index 46452d972407..9650cecee986 100644 --- a/utils/nfsd/nfssvc.c +++ b/utils/nfsd/nfssvc.c @@ -205,7 +205,8 @@ nfssvc_setfds(const struct addrinfo *hints, const char *node, const char *port) rc = errno; goto error; } - if (addr->ai_protocol == IPPROTO_TCP && listen(sockfd, 64)) { + if (addr->ai_protocol == IPPROTO_TCP && + listen(sockfd, SOMAXCONN)) { xlog(L_ERROR, "unable to create listening socket: " "errno %d (%m)", errno); rc = errno;Steve, Is there some reason you've not committed this patch? It seems fairly straightforward. I think I sent this earlier, but: Reviewed-by: Jeffrey Layton <jlayton@xxxxxxxxxx>
Thanks for the poke... The patch was not on my todo list. I'm on it... steved.
