On Mon, May 06, 2024 at 12:30:04PM -0400, trondmy@xxxxxxxxxx wrote:
> From: Trond Myklebust <trond.myklebust@xxxxxxxxxxxxxxx>
>
> The 'NFS error' NFSERR_OPNOTSUPP is not described by any of the official
> NFS related RFCs, but appears to have snuck into some older .x files for
> NFSv2.
> Either way, it is not in RFC1094, RFC1813 or any of the NFSv4 RFCs, so
> should not be returned by the knfsd server, and particularly not by the
> "LOOKUP" operation.
>
> Instead, let's return NFSERR_STALE, which is more appropriate if the
> filesystem encodes the filehandle as FILEID_INVALID.
>
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Trond Myklebust <trond.myklebust@xxxxxxxxxxxxxxx>
> ---
> fs/nfsd/nfsfh.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Hi, both applied to nfsd-next (for v6.10). Thanks!
> diff --git a/fs/nfsd/nfsfh.c b/fs/nfsd/nfsfh.c
> index dbfa0ac13564..d41e7630eb7a 100644
> --- a/fs/nfsd/nfsfh.c
> +++ b/fs/nfsd/nfsfh.c
> @@ -572,7 +572,7 @@ fh_compose(struct svc_fh *fhp, struct svc_export *exp, struct dentry *dentry,
> _fh_update(fhp, exp, dentry);
> if (fhp->fh_handle.fh_fileid_type == FILEID_INVALID) {
> fh_put(fhp);
> - return nfserr_opnotsupp;
> + return nfserr_stale;
> }
>
> return 0;
> @@ -598,7 +598,7 @@ fh_update(struct svc_fh *fhp)
>
> _fh_update(fhp, fhp->fh_export, dentry);
> if (fhp->fh_handle.fh_fileid_type == FILEID_INVALID)
> - return nfserr_opnotsupp;
> + return nfserr_stale;
> return 0;
> out_bad:
> printk(KERN_ERR "fh_update: fh not verified!\n");
> --
> 2.45.0
>
--
Chuck Lever
