On 12/5/09 12:34 PM, "Trond Myklebust" <Trond.Myklebust@xxxxxxxxxx> wrote: > On Sat, 2009-12-05 at 12:11 -0800, Ricardo Labiaga wrote: >> The state manager was not marking the stateids as needing to be reclaimed >> after reestablishing the clientid. >> >> Signed-off-by: Ricardo Labiaga <Ricardo.Labiaga@xxxxxxxxxx> >> --- >> fs/nfs/nfs4state.c | 1 + >> 1 files changed, 1 insertions(+), 0 deletions(-) >> >> diff --git a/fs/nfs/nfs4state.c b/fs/nfs/nfs4state.c >> index 630199d..ae90df8 100644 >> --- a/fs/nfs/nfs4state.c >> +++ b/fs/nfs/nfs4state.c >> @@ -1157,6 +1157,7 @@ static void nfs4_session_recovery_handle_error(struct >> nfs_client *clp, int err) >> case -NFS4ERR_STALE_CLIENTID: >> set_bit(NFS4CLNT_LEASE_EXPIRED, &clp->cl_state); >> set_bit(NFS4CLNT_SESSION_SETUP, &clp->cl_state); >> + nfs4_state_start_reclaim_reboot(clp); >> } >> } >> > > So, why do we need a special nfs4_session_recovery_handle_error() that > just mirrors the existing nfs4_recovery_handle_error(). > Good point. The early exit from nfs4_state_end_reclaim_reboot() if NFS4CLNT_RECLAIM_REBOOT is set makes it equivalent. I'll make the change. - ricardo > Please just get rid of it... > > Trond -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
