Re: [PATCH v7 2/5] NFSD: add write_version to netlink command

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH v7 2/5] NFSD: add write_version to netlink command
From: Jakub Kicinski <kuba@xxxxxxxxxx>
Date: Mon, 15 Apr 2024 11:03:20 -0700
Cc: linux-nfs@xxxxxxxxxxxxxxx, lorenzo.bianconi@xxxxxxxxxx, chuck.lever@xxxxxxxxxx, jlayton@xxxxxxxxxx, neilb@xxxxxxx, netdev@xxxxxxxxxxxxxxx
In-reply-to: <bd85d1a774cb362ab9f70ac6a2af70d9ed7a309e.1712853394.git.lorenzo@kernel.org>
References: <cover.1712853393.git.lorenzo@kernel.org> <bd85d1a774cb362ab9f70ac6a2af70d9ed7a309e.1712853394.git.lorenzo@kernel.org>

On Thu, 11 Apr 2024 18:47:25 +0200 Lorenzo Bianconi wrote:
> +			attr = nla_nest_start_noflag(skb,
> +					NFSD_A_SERVER_PROTO_VERSION);

The _noflag() version is for legacy code, I think you should let 
the nest be marked appropriately.

References:
- [PATCH v7 0/5] convert write_threads, write_version and write_ports to netlink commands
  - From: Lorenzo Bianconi
- [PATCH v7 2/5] NFSD: add write_version to netlink command
  - From: Lorenzo Bianconi

Prev by Date: Re: [PATCH 1/1] proc01: Whitelist /proc/fs/nfsd/nfsv4recoverydir
Next by Date: [PATCH v8 0/6] convert write_threads, write_version and write_ports to netlink commands
Previous by thread: Re: [PATCH v7 2/5] NFSD: add write_version to netlink command
Next by thread: [PATCH v7 3/5] SUNRPC: introduce svc_xprt_create_from_sa utility routine
Index(es):
- Date
- Thread

[Index of Archives] [Linux Filesystem Development] [Linux USB Development] [Linux Media Development] [Video for Linux] [Linux NILFS] [Linux Audio Users] [Yosemite Info] [Linux SCSI]

Powered by Linux