On Tue, Apr 09, 2024 at 09:21:54AM +1000, NeilBrown wrote:
> On Tue, 09 Apr 2024, Chen Hanxiao wrote:
> > trace_nfsd_ctl_filehandle in write_filehandle has
> > some similar infos.
>
> Not all that similar. The dprintk you are removing includes the inode
> number and sb->s_id which the trace point don't include.
>
> Why do you think that information isn't needed?
I asked him to remove that dprintk.
Can you say why you think that information is useful to provide
via a dprintk? It doesn't seem useful to system administrators,
IMO.
> > write_filehandle is the only caller of exp_rootfh,
> > so just remove the dprintk parts.
> >
> > Signed-off-by: Chen Hanxiao <chenhx.fnst@xxxxxxxxxxx>
> > ---
> > fs/nfsd/export.c | 3 ---
> > 1 file changed, 3 deletions(-)
> >
> > diff --git a/fs/nfsd/export.c b/fs/nfsd/export.c
> > index 7b641095a665..e7acd820758d 100644
> > --- a/fs/nfsd/export.c
> > +++ b/fs/nfsd/export.c
> > @@ -1027,9 +1027,6 @@ exp_rootfh(struct net *net, struct auth_domain *clp, char *name,
> > }
> > inode = d_inode(path.dentry);
> >
> > - dprintk("nfsd: exp_rootfh(%s [%p] %s:%s/%ld)\n",
> > - name, path.dentry, clp->name,
> > - inode->i_sb->s_id, inode->i_ino);
> > exp = exp_parent(cd, clp, &path);
> > if (IS_ERR(exp)) {
> > err = PTR_ERR(exp);
> > --
> > 2.39.1
> >
> >
> >
>
--
Chuck Lever
