Re: [PATCH 6/7] nfsd: restrict filehandles accepted in V4ROOT case

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Dec 04, 2009 at 10:05:09AM -0500, Steve Dickson wrote:
> 
> 
> On 12/01/2009 07:39 PM, J. Bruce Fields wrote:
> > +	/*
> > +	 * A pseudoroot export gives permission to access only one
> > +	 * single directory; the kernel has to make another upcall
> > +	 * before granting access to anything else under it:
> > +	 */
> > +	if (unlikely(dentry->d_parent != exp->ex_path.dentry))
> Remember this is wrong... it needs to be 
> -	if (unlikely(dentry->d_parent != exp->ex_path.dentry))
> +	if (unlikely(dentry != exp->ex_path.dentry))

Oops, thanks.  Looking back through the git reflogs....  It seems that I
had this fix in a separate patch, was rebasing the series and squashing
that patch in at the same time, and missed this chunk.  Fixed in my
local version.

--b.
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux