On Wed, Feb 28, 2024 at 10:25:49AM +1100, NeilBrown wrote:
>
> when AOP_WRITEPAGE_ACTIVATE is returned (as NFS does when it detects
> congestion) it is important that the page is redirtied.
> nfs_writepage_locked() doesn't do this, so files can become corrupted as
> writes can be lost.
>
> Note that this is not needed in v6.8 as AOP_WRITEPAGE_ACTIVATE cannot be
> returned. It is needed for kernels v5.18..v6.7. From 6.3 onward the patch
> is different as it needs to mention "folio", not "page".
>
> Reported-and-tested-by: Jacek Tomaka <Jacek.Tomaka@xxxxxxxxx>
> Fixes: 6df25e58532b ("nfs: remove reliance on bdi congestion")
> Signed-off-by: NeilBrown <neilb@xxxxxxx>
> ---
> fs/nfs/write.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
All now queued up, thanks.
greg k-h
