On Tue, Nov 24, 2009 at 10:28:59AM +0200, Boaz Harrosh wrote: > On 11/24/2009 12:17 AM, J. Bruce Fields wrote: > > On Mon, Nov 23, 2009 at 05:58:30PM +0200, Boaz Harrosh wrote: > >> linux/nfsd/nfsfh.h defines some low level types which > >> are needed by exportfs and though by filesystems. > >> > >> In the file, fh_lock() uses the sunrpc dprint facility which > >> might cause a dependency of exportfs (and filesystems) on > > > > "might cause"? > > > > Does mere inclusion of this .h (without referencing fh_lock_nested() or > > its callers) actually create a dependency? > > > > --b. > > > > No, only if code actually uses fh_lock_nested it will cause a dependency. > Which is only used in fs/nfsd/... > > But I would like to discourage nfsd/debug.h at this level. > > Should I move fh_lock_nested() and it's siblings to the new private vfs.h header > you made, and get rid of it this way? Sure, that sounds reasonable. --b. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
