On 26 Jan 2024, at 15:37, Jorge Mora wrote: > Thanks Ben, > > Do you want me to resubmit the patch using XDR_QUALEN? Something like this? > > static inline u32 nfs42_listxattr_xdrsize(u32 buflen) > { > - return ((buflen / (XATTR_USER_PREFIX_LEN + 2)) * 8) + 4; > + u32 size = 8 * buflen / (XATTR_USER_PREFIX_LEN + 2) + 4; > + > + return XDR_QUADLEN(size) << 2; I just thought I'd mention it since it's used all over. I think your version is just fine. Ben