On Mon, 2024-01-08 at 10:16 -0800, Breno Leitao wrote:
> W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
> Add descriptions to Sun RPC modules.
>
> Signed-off-by: Breno Leitao <leitao@xxxxxxxxxx>
> ---
> net/sunrpc/auth_gss/auth_gss.c | 1 +
> net/sunrpc/auth_gss/gss_krb5_mech.c | 1 +
> net/sunrpc/sunrpc_syms.c | 1 +
> 3 files changed, 3 insertions(+)
>
> diff --git a/net/sunrpc/auth_gss/auth_gss.c b/net/sunrpc/auth_gss/auth_gss.c
> index 1af71fbb0d80..c7af0220f82f 100644
> --- a/net/sunrpc/auth_gss/auth_gss.c
> +++ b/net/sunrpc/auth_gss/auth_gss.c
> @@ -2280,6 +2280,7 @@ static void __exit exit_rpcsec_gss(void)
> }
>
> MODULE_ALIAS("rpc-auth-6");
> +MODULE_DESCRIPTION("Sun RPC Kerberos RPCSEC_GSS client authentication");
> MODULE_LICENSE("GPL");
> module_param_named(expired_cred_retry_delay,
> gss_expired_cred_retry_delay,
> diff --git a/net/sunrpc/auth_gss/gss_krb5_mech.c b/net/sunrpc/auth_gss/gss_krb5_mech.c
> index e31cfdf7eadc..64cff717c3d9 100644
> --- a/net/sunrpc/auth_gss/gss_krb5_mech.c
> +++ b/net/sunrpc/auth_gss/gss_krb5_mech.c
> @@ -650,6 +650,7 @@ static void __exit cleanup_kerberos_module(void)
> gss_mech_unregister(&gss_kerberos_mech);
> }
>
> +MODULE_DESCRIPTION("Sun RPC Kerberos 5 module");
> MODULE_LICENSE("GPL");
> module_init(init_kerberos_module);
> module_exit(cleanup_kerberos_module);
> diff --git a/net/sunrpc/sunrpc_syms.c b/net/sunrpc/sunrpc_syms.c
> index 691c0000e9ea..bab6cab29405 100644
> --- a/net/sunrpc/sunrpc_syms.c
> +++ b/net/sunrpc/sunrpc_syms.c
> @@ -148,6 +148,7 @@ cleanup_sunrpc(void)
> #endif
> rcu_barrier(); /* Wait for completion of call_rcu()'s */
> }
> +MODULE_DESCRIPTION("Sun RPC core");
> MODULE_LICENSE("GPL");
> fs_initcall(init_sunrpc); /* Ensure we're initialised before nfs */
> module_exit(cleanup_sunrpc);
Looks reasonable to me.
Reviewed-by: Jeff Layton <jlayton@xxxxxxxxxx>
