On Tue, Dec 26, 2023 at 3:20 PM Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote: > > Hi, > > On 12/26/23 13:23, Tanzir Hasan wrote: > > asm-generic/barrier.h and asm/bitops.h are already brought into the > > header and the file can still be built with their removal. > > Brought into which header? Hi Randy, Sorry for the poor explanation. I see that I left out the specific header. The inclusion of linux/sunrpc/svc_rdma.h brings in linux/sunrpc/rpc_rdma.h This brings in linux/bitops.h which is preferred over asm/bitops.h > Does this conflict with Rule #1 in Documentation/process/submit-checklist.rst ? Yes, this conflicts with Rule #1. A better version of this patch would be to add linux/bitops.h to this file directly. The main reason this patch exists is to clear out the asm-generic file since those are not preferred. I can do this by either including just linux/bitops.h or including both linux/bitops.h and asm/barrier.h. Would the second approach conform better with Rule #1? Thanks, Tanzir
