On Fri, 2023-12-15 at 11:56 +1100, NeilBrown wrote: > I sent an earlier version of this series, got some feed back, revised > it, but never sent it again. Sorry. > > The main feedback was around the interaction between sunrpc and nfsd for > handling poolstats. I have changed that so that nfsd tells sunrpc where > the svc_serv pointer lives, and where to find a mutex to protect it. > sunrpc then taks the mutex and accesses the pointer - if not NULL. I > think this is nicer than the version that pass around funciton pointers. > > This series is against nfsd-next > > Thanks, > NeilBrown > > > [PATCH 1/5] nfsd: call nfsd_last_thread() before final nfsd_put() > [PATCH 2/5] svc: don't hold reference for poolstats, only mutex. > [PATCH 3/5] nfsd: hold nfsd_mutex across entire netlink operation > [PATCH 4/5] SUNRPC: discard sv_refcnt, and svc_get/svc_put > [PATCH 5/5] nfsd: rename nfsd_last_thread() to nfsd_destroy_serv() I'm not sure patch #2 is better than the version with function pointers, but it seems reasonable. Note that patch #1 probably needs to go to v6.6 stable, and I think we want #3 in v6.7 before it ships. I think I sent this on the earlier set, but I'll send it again: Reviewed-by: Jeff Layton <jlayton@xxxxxxxxxx>
