On 10/27/2009 04:20 PM, Chuck Lever wrote:
> Hi-
>
> On Oct 27, 2009, at 4:02 PM, Steve Dickson wrote:
>
>> Author: Steve Dickson <steved@xxxxxxxxxx>
>> Date: Tue Oct 27 15:47:27 2009 -0400
>>
>> Added wrappers around the setting of default values
>> from the config file which will be compiled out
>> when the config file is not enabled.
>>
>> Signed-off-by: Steve Dickson <steved@xxxxxxxxxx>
>>
>> diff --git a/support/include/conffile.h b/support/include/conffile.h
>> index fe23ec2..ce7aa21 100644
>> --- a/support/include/conffile.h
>> +++ b/support/include/conffile.h
>> @@ -76,10 +76,5 @@ static inline void upper2lower(char *str)
>> *str++ = c;
>> }
>>
>> -/*
>> - * Default Mount options
>> - */
>> -extern unsigned long config_default_vers;
>> -extern unsigned long config_default_proto;
>>
>> #endif /* _CONFFILE_H_ */
>> diff --git a/utils/mount/network.c b/utils/mount/network.c
>> index e651167..d4ecbc9 100644
>> --- a/utils/mount/network.c
>> +++ b/utils/mount/network.c
>> @@ -172,6 +172,27 @@ static const unsigned long probe_mnt3_first[] = {
>> 0,
>> };
>>
>> +inline const unsigned int *set_default_proto(void);
>
> The "inline" directives are visual clutter, really... shouldn't this be
> "static" instead (which in most normal cases implies "inline")?
> Otherwise, you also clutter up the linker's symbol name space with these
> generic function names. I've been prefixing function names with "nfs_"
> for most global functions, to make debugging easier.
I made these changes a while ago... I guess I forgot to mention
it... thanks of the input!
steved.
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
