From: Chuck Lever <chuck.lever@xxxxxxxxxx> Neil Brown says: > The only thing that was interesting is that nfsref.c includes > sys/capability.h, and I didn't have libcap declared as BuildRequires. > The ./configure script didn't complain that libcap was missing - instead > the build failed. > > Other places in nfs-utils that include capability.h protect it with > #ifdef HAVE_SYS_CAPABILITY_H > > If nfsref.c followed that pattern I wouldn't have received an error. > But then I wouldn't have added a dependency on libcap. > Do I really want libcap?? I don't know. > But I cannot see where nfsref.c uses libcap or prctl. So maybe > those includes aren't needed. Signed-off-by: Chuck Lever <chuck.lever@xxxxxxxxxx> --- utils/nfsref/nfsref.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/utils/nfsref/nfsref.c b/utils/nfsref/nfsref.c index 7f97d01f55ca..aa8414b425fb 100644 --- a/utils/nfsref/nfsref.c +++ b/utils/nfsref/nfsref.c @@ -24,8 +24,6 @@ */ #include <sys/types.h> -#include <sys/capability.h> -#include <sys/prctl.h> #include <sys/stat.h> #include <stdbool.h>
