Hi Lorenzo, kernel test robot noticed the following build warnings: [auto build test WARNING on linus/master] [also build test WARNING on next-20231103] [cannot apply to trondmy-nfs/linux-next v6.6] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Lorenzo-Bianconi/NFSD-convert-write_threads-to-netlink-command/20231104-202515 base: linus/master patch link: https://lore.kernel.org/r/3785da26e14c13e194510eaad9c6bd846d691d5f.1699095665.git.lorenzo%40kernel.org patch subject: [PATCH v4 2/3] NFSD: convert write_version to netlink command config: alpha-defconfig (https://download.01.org/0day-ci/archive/20231104/202311042320.nQOTYxhs-lkp@xxxxxxxxx/config) compiler: alpha-linux-gcc (GCC) 13.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231104/202311042320.nQOTYxhs-lkp@xxxxxxxxx/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Closes: https://lore.kernel.org/oe-kbuild-all/202311042320.nQOTYxhs-lkp@xxxxxxxxx/ All warnings (new ones prefixed by >>): >> fs/nfsd/nfsctl.c:1810: warning: expecting prototype for nfsd_nl_version_get_doit(). Prototype was for nfsd_nl_version_get_dumpit() instead vim +1810 fs/nfsd/nfsctl.c 1800 1801 /** 1802 * nfsd_nl_version_get_doit - Handle verion_get dumpit 1803 * @skb: reply buffer 1804 * @cb: netlink metadata and command arguments 1805 * 1806 * Returns the size of the reply or a negative errno. 1807 */ 1808 int nfsd_nl_version_get_dumpit(struct sk_buff *skb, 1809 struct netlink_callback *cb) > 1810 { 1811 struct nfsd_net *nn = net_generic(sock_net(skb->sk), nfsd_net_id); 1812 int i, ret = -ENOMEM; 1813 1814 mutex_lock(&nfsd_mutex); 1815 1816 for (i = 2; i <= 4; i++) { 1817 int j; 1818 1819 if (i < cb->args[0]) /* already consumed */ 1820 continue; 1821 1822 if (!nfsd_vers(nn, i, NFSD_AVAIL)) 1823 continue; 1824 1825 for (j = 0; j <= NFSD_SUPPORTED_MINOR_VERSION; j++) { 1826 void *hdr; 1827 1828 if (!nfsd_vers(nn, i, NFSD_TEST)) 1829 continue; 1830 1831 /* NFSv{2,3} does not support minor numbers */ 1832 if (i < 4 && j) 1833 continue; 1834 1835 if (i == 4 && !nfsd_minorversion(nn, j, NFSD_TEST)) 1836 continue; 1837 1838 hdr = genlmsg_put(skb, NETLINK_CB(cb->skb).portid, 1839 cb->nlh->nlmsg_seq, &nfsd_nl_family, 1840 0, NFSD_CMD_VERSION_GET); 1841 if (!hdr) 1842 goto out; 1843 1844 if (nla_put_u32(skb, NFSD_A_SERVER_VERSION_MAJOR, i) || 1845 nla_put_u32(skb, NFSD_A_SERVER_VERSION_MINOR, j)) 1846 goto out; 1847 1848 genlmsg_end(skb, hdr); 1849 } 1850 } 1851 cb->args[0] = i; 1852 ret = skb->len; 1853 out: 1854 mutex_unlock(&nfsd_mutex); 1855 1856 return ret; 1857 } 1858 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
