On Wed, 2023-11-01 at 11:57 +1100, NeilBrown wrote: > This set fixes two issues found by kernel test robot > 1/ nfsd4_revoke_states() needs to be defined when not CONFIG_NFSD_V4 > 2/ nfs40_last_revoke is larger than a mechine word in 32 bit configs, > so needs protection - use nn->client_lock which is already taken when > nfs40_last_revoke is accessed. > > NeilBrown > In general, the series looks like something reasonable to do (and something admins would welcome). I have some (long standing) concerns around the sc_type value though that I think we probably need to address prior to or in conjunction with this set. Cheers, -- Jeff Layton <jlayton@xxxxxxxxxx>