On Fri, Oct 27, 2023 at 9:05 AM Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote: > > On Mon, Oct 23, 2023 at 09:08:00PM +0300, Amir Goldstein wrote: > > Similar to the common FILEID_INO32* file handle types, define common > > FILEID_INO64* file handle types. > > > > The type values of FILEID_INO64_GEN and FILEID_INO64_GEN_PARENT are the > > values returned by fuse and xfs for 64bit ino encoded file handle types. > > Please actually switch xfs to fully use the helpers instead of > duplicating the logic. I will follow up with another patch. > Presumable the same for fuse, but for that > I'd need to look at how it works for fuse right now and if there's not > some subtle differences. > There are subtle differences: 1. fuse encodes an internal nodeid - not i_ino 2. fuse encodes the inode number as [low32,high32] It cannot use the generic helper. Thanks, Amir.
