Re: [PATCH] proc: revalidate dentry returned by proc_pid_follow_link

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jeff Layton <jlayton@xxxxxxxxxx> writes:

>> Hmm.  Looking at the code I get the impression that a file bind mount
>> will have exactly the same problem.
>> 
>> Can you confirm.
>> 
>> If file bind mounts also have this problem a bugfix to to just
>> proc seems questionable.
>> 
>
> I'm not sure I understand what you mean by "file bind mount". Is that
> something like mounting with "-o loop" ?

# cd /tmp
# echo foo > foo
# echo bar > bar
# mount --bind foo bar
# cat bar
foo
#

> I'm not at all opposed to fixing this in a more broad fashion, but as
> best I can tell, the only place that LAST_BIND is used is in procfs.

proc does appear to be the only user of LAST_BIND.  With a file bind
mount we can get to the same ok: label without a revalidate.  The
difference is that we came from __follow_mount instead of follow_link.

At least that is how I read the code.

Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux