On 09/13/2009 11:27 PM, J. Bruce Fields wrote: > On Thu, Sep 10, 2009 at 12:26:51PM +0300, Benny Halevy wrote: >> Implement the cb_sequence callback conforming to draft-ietf-nfsv4-minorversion1 >> >> Note: highest slot id and target highest slot id do not have to be 0 >> as was previously implemented. They can be greater than what the >> nfs server sent if the client supports a larger slot table on the >> backchannel. At this point we just ignore that. > > Minor point (applying as is), but, in future: a changelog that says how > this version of the patch differs from a previous version won't be > useful to someone reading the git history (and lacking the previous > versions). If you think the above mistake is one that someone might > risk making again, a comment in the appropriate spot in the code might > be more useful. > > --b. > I disagree. The paragraph above is perfectly understandable if you just remove the "as was previously implemented". There is no missing information. Then if so, the "as was previously implemented" is useful extra information that says that "we tried that before and it was bad". This is the kind of information that is important to a reader, even without reading the old version. Just my $0.017 Boaz -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
