On Wed, Aug 12, 2009 at 06:21:48PM +0300, Benny Halevy wrote:
> ntohl is already defined as be32_to_cpu.
> be64_to_cpu has architecture specific optimized implementations.
> static inline __be32 *
> xdr_decode_hyper(__be32 *p, __u64 *valp)
> {
> - *valp = ((__u64) ntohl(*p++)) << 32;
> - *valp |= ntohl(*p++);
> - return p;
> + *valp = be64_to_cpup((__be64 *)p);
> + return p + 2;
> }
Erm... Who has promised you that p will be 64bit-aligned?
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
