I'm looking at a 2008 nfs-utils clean up done in commit 7a817c45. It
has this hunk in it:
@@ -111,7 +111,7 @@ void auth_unix_ip(FILE *f)
else if (client)
qword_print(f, *client?client:"DEFAULT");
qword_eol(f);
- xlog(D_CALL, "auth_unix_ip: client %p '%s'", client, *client?
client: "DEFAULT");
+ xlog(D_CALL, "auth_unix_ip: client %p '%s'", client, client?
client: "DEFAULT");
if (client) free(client);
free(he);
You changed the '*client ? client : "DEFAULT"' expression in the
xlog() call, but not in the qword_print() call right above it. Which
of these is correct, and why do they need to be different from each
other?
Seems to me _both_ should be 'client ? client : "DEFAULT"' (ie.
without the dereference).
--
Chuck Lever
chuck[dot]lever[at]oracle[dot]com
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
