On Mon, 2009-08-24 at 16:26 +0300, Boaz Harrosh wrote: > On 08/24/2009 03:59 PM, Trond Myklebust wrote: > > On Mon, 2009-08-24 at 15:50 +0300, Boaz Harrosh wrote: > >> On 08/24/2009 02:56 PM, Trond Myklebust wrote: > > In any case, I don't apply patches based on popular vote. I apply them > > based on my conviction that they are useful. > > > > I think you need a reality check. Just look in the mailing list archives. No Boaz. YOU need the reality check. As I said above, I don't apply patches based on popular vote. I'm open to be persuaded that something is useful and helps maintainability of the code, but I'm not open to coercive tactics such as people telling me that I'm being irrational, and that I should do what the "Big Majority" (consisting so far of 2 people) wants. > > I mean that the fundamental type of XDR is a __be32. We are using that > > fundamental type in standard C code. > > I heavily use beXX types in code totally unrelated to XDR. Please don't hijack > _beXX to mean XDR, for me they are just unrelated overlapping subjects. ??? We don't have a special 'XDR' type, and I didn't say '__beXX' is XDR. I said that the fundamental type that we use in XDR encoding and decoding is a __b32. That's why you get to declare __be32 *p; at the top of each XDR function. Then you get to encode the contents of that '__be32' declared memory location using the standard Linux C functions for manipulating '__be32' type. If you don't like the names of those standard functions, then complain to the people who named them. > > The fundamental Linux function for converting from a u32 to a __be32 is > > cpu_to_be32(). It doesn't need a new wrapper, and neither does > > be32_to_cpu(). > > > > And that is exactlly why I use them inside "my" xdr-wrapper. But the xdr wrapper > for me is to do with calling convention, uniformity of code, and statement of intent. > My wrapper is not about byte-ness it is about calling convention and that pointer arithmetic > which you don't like, and I do. I repeat: we don't have a special 'XDR' type. We have __be32. -- Trond Myklebust Linux NFS client maintainer NetApp Trond.Myklebust@xxxxxxxxxx www.netapp.com -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
