On 08/07/2009 03:38 AM, Benny Halevy wrote: > On Aug. 06, 2009, 21:42 +0300, Steve Dickson <SteveD@xxxxxxxxxx> wrote: >> commit 3d08862cfebb9fb8a360d362bb9e5e761e6b1fb5 >> Author: Steve Dickson <steved@xxxxxxxxxx> >> Date: Wed Aug 5 15:53:36 2009 -0400 >> >> Make Section names case-insensitive which should >> help in locating them resulting in make the config >> files a bit less error prone >> >> Signed-off-by: Steve Dickson <steved@xxxxxxxxxx> >> >> diff --git a/support/nfs/conffile.c b/support/nfs/conffile.c >> index 5f491eb..a8b8037 100644 >> --- a/support/nfs/conffile.c >> +++ b/support/nfs/conffile.c >> @@ -116,6 +116,18 @@ conf_hash(char *s) >> } >> >> /* >> + * Convert letter from upper case to lower case >> + */ >> +static inline void upper2lower(char *str) >> +{ >> + char *ptr = str; >> + >> + while (*ptr) >> + *ptr++ = tolower(*ptr); >> +} >> + > > nit: to optimize this function a tiny bit you can also do: > > static inline void upper2lower(char *str) > { > char c; > > while ((c = tolower(*str))) > *str++ = c; > } Point. I'll convert this during the commit or next re-spin... steved. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html