On 08/03/2009 11:56 AM, J. Bruce Fields wrote: > On Mon, Aug 03, 2009 at 11:48:56AM -0400, Steve Dickson wrote: >> >> On 08/03/2009 11:24 AM, J. Bruce Fields wrote: >>> On Mon, Aug 03, 2009 at 10:53:29AM -0400, Steve Dickson wrote: >>>> commit 528e270be6bb3e4a072cbbb7f3a8b378b64b7fba >>>> Author: Steve Dickson <steved@xxxxxxxxxx> >>>> Date: Mon Mar 9 13:57:10 2009 -0400 >>>> >>>> Store values in lower case. This makes it easier to do string >>>> comparisons when reading lists from the configuration file. >>> Just curious--which parts of the configuration file (section headers, >>> keys, values--looks like maybe all 3?) are you making case-insensitive, >>> and why do they need to be? >> Yes all three of them... >>> E.g. the idmapd configuration file contains paths and user/group names, >>> and both those still need to be case sensitive. >> hmm... good point... I would suspect this might be the case for >> all users of these routines since pathnames and user/group names >> are always case-sensitive.... >> >> I would guess both the section and keys can be case-insensitive >> but the key probably say case-sensitive... > > If you're using mount paths, for example, in the section names, then > that part also needs to be case-sensitive. > > Probably the right thing to do is to leave the core config-file code out > of the business of playing with case, and let the callers do it in > particular cases when it's appropriate. After thinking about this.. I've convinced myself that the internal parsing routines should make the Section names case-insensitive but the rest of the data (i.e the tag, value) should be returned as is and let the callers deal with the case... The reason being everything hangs off Section names. So making those easier to find I think is a good thing and hopefully it will make managing config files a bit less error prone.... steved. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
