On Sat, 01 Aug 2009 07:35:50 -0400
Steve Dickson <SteveD@xxxxxxxxxx> wrote:
> On 06/08/2009 02:00 PM, Jeff Layton wrote:
> > static void
> > nfssvc_versbits(unsigned int ctlbits, int minorvers4)
> > {
> > @@ -180,8 +246,11 @@ nfssvc(int port, int nrservs, unsigned int versbits, int minorvers4,
> > * the ports get registered with portmap against correct
> > * versions
> > */
> > - nfssvc_versbits(versbits, minorvers4);
> > - nfssvc_setfds(port, protobits, haddr);
> > + if (!nfssvc_inuse()) {
> > + nfssvc_versbits(versbits, minorvers4);
> > + snprintf(buf, sizeof(buf), "%d", port);
> > + nfssvc_set_sockets(AF_INET, protobits, haddr, portstr);
> portstr is not defined here.... and as far as I can tell its not
> defined in any of the next 3 patches either...
>
> What am I missing or it is missing?
>
> steved.
>
You're right. That's a spot that I missed when I converted that code to
use the static buffer instead of allocating a memory all over the
place. That "portstr" should be "buf" instead.
The good news is that a later patch removes that entire if statement.
The final outcome of the set shouldn't be affected by this. Would you
like me to respin that patch and the later one that removes that chunk
of code?
--
Jeff Layton <jlayton@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
