On Tue, Jul 28, 2009 at 04:03:48PM +0100, Catalin Marinas wrote: > 2009/7/28 Eric Sesterhenn <eric.sesterhenn@xxxxxxxxxxxxx>: > > kmemcheck produces the following warning > > That's "kmemleak" (a bit confusing since there is "kmemcheck" as well > in the kernel :-)). Thanks, fixed up changelog and added a Reviewed-by: Catalin Marinas <catalin.marinas@xxxxxxx>. --b. > > unreferenced object 0xc9ec02a0 (size 8): > > comm "cat", pid 19048, jiffies 730243 > > backtrace: > > [<c01bf970>] create_object+0x100/0x240 > > [<c01bfadb>] kmemleak_alloc+0x2b/0x60 > > [<c01bcd4b>] __kmalloc+0x14b/0x270 > > [<c02fd027>] write_pool_threads+0x87/0x1d0 > > [<c02fcc08>] nfsctl_transaction_write+0x58/0x70 > > [<c02fcc6f>] nfsctl_transaction_read+0x4f/0x60 > > [<c01c2574>] vfs_read+0x94/0x150 > > [<c01c297d>] sys_read+0x3d/0x70 > > [<c0102d6b>] sysenter_do_call+0x12/0x32 > > [<ffffffff>] 0xffffffff > > > > write_pool_threads() only frees nthreads on error paths, in the success case > > we leak it. > > > > Signed-off-by: Eric Sesterhenn <eric.sesterhenn@xxxxxxxxxxxx> > > > > --- linux/fs/nfsd/nfsctl.c.orig 2009-07-28 14:19:19.000000000 +0200 > > +++ linux/fs/nfsd/nfsctl.c 2009-07-28 14:19:30.000000000 +0200 > > @@ -784,6 +784,7 @@ static ssize_t write_pool_threads(struct > > mesg += len; > > } > > > > + kfree(nthreads); > > mutex_unlock(&nfsd_mutex); > > return (mesg-buf); > > Thanks for this. On minor point - the kfree() could probably be moved > after mutex_unlock(). > > I added the patch to the kmemleak-fixes branch on > git://linux-arm.org/linux-2.6.git (I'm not pushing this branch > upstream, it's mainly for people trying kmemleak to avoid reporting or > investigating already fixed leaks). > > -- > Catalin > -- > To unsubscribe from this list: send the line "unsubscribe linux-nfs" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
