On Tue, 2009-07-21 at 17:17 -0400, Trond Myklebust wrote: > On Tue, 2009-07-21 at 11:32 -0700, Ben Greear wrote: > > On 07/21/2009 11:28 AM, Trond Myklebust wrote: > > > On Tue, 2009-07-21 at 11:01 -0700, Ben Greear wrote: > > >> On 07/21/2009 10:59 AM, Trond Myklebust wrote: > > >>> On Tue, 2009-07-21 at 10:36 -0700, Ben Greear wrote: > > >>>> On 07/21/2009 10:12 AM, Trond Myklebust wrote: > > >>>>> On Tue, 2009-07-21 at 09:49 -0700, Ben Greear wrote: > > >>>>>> On 07/21/2009 05:15 AM, Trond Myklebust wrote: > > >>>>>> > > >>>>>>> What does /var/lib/nfs/v4recovery look like on the server? > > >>>>>> The server was misconfigured, but I still think the client should > > >>>>>> behave better in this case. If you cannot reproduce it, let me know > > >>>>>> and I can try to be more specific. If you still want the v4recovery > > >>>>>> information, let me know and I'll send it. > > >>>>> So how should the client behave, when a screwed up server allows it to > > >>>>> mount but starts returning illegal values for setclientid? The only > > >>>>> thing I can see we could do is to tell the user EINSANESERVER... > > >>>> Well, it could just fail the mount and give up and not overly spam > > >>>> /var/log/messages in a tight loop perhaps? > > >>> This doesn't happen at mount time. It happens when you open a file. > > >> Not for me, and evidently not for the other person that reported > > >> similar results. All I had to do was attempt the mount (which never > > >> completed). > > >> > > >> Thanks, > > >> Ben > > > > > > Ah... You have NFS_V4_1 enabled despite the Kconfig warning... Does the > > > bug occur when you turn this off too? > > > > Yes, it did. > > OK. The following patch should fix that particular regression. > > Note that there is a bug remaining inside nfs4_init_session(): we > shouldn't be copying the rsize/wsize into the nfs_client if the latter > was already initialised. I'm going to leave that for the moment, though, > since that bug wasn't introduced by my patch, and it doesn't affect > NFSv4.0. With that patch applied, I now get the expected behaviour when mounting a server with no NFSv4 root from a 2.6.31-rc3 based client: root@heimdal:~# mount -t nfs4 munkholm.local:/ /mnt mount.nfs4: mounting munkholm.local:/ failed, reason given by server: No such file or directory Trond -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
