Re: [PATCH] SUNRPC: handle IPv6 PKTINFO when extracting destination address

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jul 13, 2009 at 10:54:26AM -0400, Chuck Lever wrote:
> PKTINFO is needed to scrape the caller's IP address off the socket so
> RPC datagram replies are routed correctly.  Fill in missing pieces in
> the kernel RPC server's UDP receive path to request IPv6 PKTINFO and
> correctly parse the IPv6 cmsg header.
> 
> Without this patch, kernel RPC services drop all incoming requests on
> UDP on IPv6.

Looks fine, thanks--applied for 2.6.32.

> @@ -531,16 +551,15 @@ static int svc_udp_recvfrom(struct svc_rqst *rqstp)
>  
>  	rqstp->rq_prot = IPPROTO_UDP;
>  
> -	if (cmh->cmsg_level != IPPROTO_IP ||
> -	    cmh->cmsg_type != IP_PKTINFO) {
> +	if (!svc_udp_get_dest_address(rqstp, cmh)) {

(Though personally I would have done this as two patches, with most of
it in a preparatory cleanup patch and the above chunk (which if I
understand right represents the only change in behavior) as the bugfix.)

--b.
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux