On Fri, Jul 10, 2009 at 08:13:55AM +0800, David Miller wrote:
> From: Wu Fengguang <fengguang.wu@xxxxxxxxx>
> Date: Thu, 9 Jul 2009 21:17:46 +0800
>
> > @@ -2100,7 +2100,8 @@ void tcp_send_fin(struct sock *sk)
> > } else {
> > /* Socket is locked, keep trying until memory is available. */
> > for (;;) {
> > - skb = alloc_skb_fclone(MAX_TCP_HEADER, GFP_KERNEL);
> > + skb = alloc_skb_fclone(MAX_TCP_HEADER,
> > + sk->sk_allocation);
> > if (skb)
> > break;
> > yield();
>
> I think this specific case needs more thinking.
>
> If the allocation fails, and it's GFP_ATOMIC, we are going to yield()
> (which sleeps) and loop endlessly waiting for the allocation to
> succeed.
The _retried_ GFP_ATOMIC won't be much worse than GFP_KERNEL.
GFP_KERNEL can directly reclaim FS pages; GFP_ATOMIC will wake up
kswapd to do that. So after yield(), GFP_ATOMIC have good opportunity
to succeed if GFP_KERNEL could succeed.
The original GFP_KERNEL does have _a bit_ better chance to succeed,
but there are no guarantee. It could loop endlessly whether it be
GFP_KERNEL or GFP_ATOMIC.
btw, generally speaking, it would be more robust that NFS set
sk_allocation to GFP_NOIO, and let the networking code choose
whether to use plain sk_allocation or (sk_allocation & ~__GFP_WAIT).
The (sk_allocation & ~__GFP_WAIT) cases should be rare, but I guess
the networking code shall do it anyway, because sk_allocation defaults
to GFP_KERNEL. It seems that currently the networking code simply uses
a lot of GFP_ATOMIC, do they really mean "I cannot sleep"?
Thanks,
Fengguang
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
