On Jun 12, 2009, at 5:08 PM, Trond Myklebust wrote:
On Fri, 2009-05-15 at 11:33 -0400, Chuck Lever wrote:
rpcbind servers do not require RPC authentication, so AUTH_NULL is
all
that is needed. This saves a few bytes on the wire, and a bit of
computational expense on both ends.
This certainly isn't the case for all portmap implementations.
What implementations require AUTH_SYS ? The libtirpc and glibc
rpcb_getaddr/pmap_getport implementations use NULL, as far as I can
tell. libtirpc rpcb_set uses a local socket, which does local
authentication. pmap_set in glib uses NULL, I think.
Are you
sure this change is safe?
We can hold off if you like.
Signed-off-by: Chuck Lever <chuck.lever@xxxxxxxxxx>
---
net/sunrpc/rpcb_clnt.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/sunrpc/rpcb_clnt.c b/net/sunrpc/rpcb_clnt.c
index beee6da..3083597 100644
--- a/net/sunrpc/rpcb_clnt.c
+++ b/net/sunrpc/rpcb_clnt.c
@@ -141,7 +141,7 @@ static struct rpc_clnt
*rpcb_create_local(struct sockaddr *addr,
.servername = "localhost",
.program = &rpcb_program,
.version = version,
- .authflavor = RPC_AUTH_UNIX,
+ .authflavor = RPC_AUTH_NULL,
.flags = RPC_CLNT_CREATE_NOPING,
};
@@ -158,7 +158,7 @@ static struct rpc_clnt *rpcb_create(char
*hostname, struct sockaddr *srvaddr,
.servername = hostname,
.program = &rpcb_program,
.version = version,
- .authflavor = RPC_AUTH_UNIX,
+ .authflavor = RPC_AUTH_NULL,
.flags = (RPC_CLNT_CREATE_NOPING |
RPC_CLNT_CREATE_NONPRIVPORT),
};
--
Trond Myklebust
Linux NFS client maintainer
NetApp
Trond.Myklebust@xxxxxxxxxx
www.netapp.com
--
Chuck Lever
chuck[dot]lever[at]oracle[dot]com
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
