Re: [PATCH 01/31] nfsd41: slots are freed with session

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



yes, you're right - it prevents an oops on server shutdown.

-->Andy

On Apr 30, 2009, at 5:12 AM, Benny Halevy wrote:

On Apr. 28, 2009, 19:59 +0300, andros@xxxxxxxxxx wrote:
From: Andy Adamson <andros@xxxxxxxxxx>

The session and slots are allocated all in one piece.

This patch should go into 2.6.30, right?

Benny


Signed-off-by: Andy Adamson <andros@xxxxxxxxxx>
---
fs/nfsd/nfs4state.c |    1 -
1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
index e82a518..42ebcb3 100644
--- a/fs/nfsd/nfs4state.c
+++ b/fs/nfsd/nfs4state.c
@@ -582,7 +582,6 @@ free_session(struct kref *kref)
		struct nfsd4_cache_entry *e = &ses->se_slots[i].sl_cache_entry;
		nfsd4_release_respages(e->ce_respages, e->ce_resused);
	}
-	kfree(ses->se_slots);
	kfree(ses);
}


--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux