Re: [PATCH 2.6.30] xprtrdma: The frmr iova_start values are truncated by the nfs rdma client.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2009-04-27 at 14:05 -0400, Trond Myklebust wrote:
> It looks looks as though the bug is really that the IB code is using a
> u64 to store dma handles. As an external user of the IB api, we really
> shouldn't have to perform this sort of transformation. If it is
> absolutely necessary, then it should be done by means of specialised
> accessor functions to initialise/read iova_start value when given a
> dma_addr_t.
> 
> I'd therefore prefer the no-cast version (with eventual compiler
> warnings), in the hope that eventually the IB folks will fix their
> interface.

Translation: It looks to me as if the interface that we're using is a
bit too corrupted with IB low level implementation grime. In the future,
I'd like to see someone come up with a more high level interface for use
by external code such as the sunrpc module.

Cheers
  Trond

--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux