On Apr. 23, 2009, 0:54 +0300, "J. Bruce Fields" <bfields@xxxxxxxxxxxx> wrote: > On Wed, Apr 22, 2009 at 03:06:30PM +0300, Benny Halevy wrote: >> Following the discussion we had last week >> (see http://linux-nfs.org/pipermail/pnfs/2009-April/007283.html) >> >> I made the following changes: >> * minorvers4 enabled by default. >> * No new -n option. >> >> This makes minorvers control essentially the same as >> the major protocol version. minorvers4 is enabled by default >> and can be disabled using -N 4.1. >> >> On Fedora, /etc/sysconfig/nfs can be changed as follows >> to configure the service startup script to disable 4.1: > > Why couldn't nfs-utils just respect the kernel's default and make no > attempt to set the minor version? A (possibly undocumented) -P 4.1 > option (or some other name) could be used by testers to specify that > they want 4.1. After things have settled down a little we'd change the > kernel's default, and then only -N 4.1 would be needed. It could, and that was pretty much my original intent, which was criticized by Steve and others for being overly cautious. I agree with Chuck that the distributions using nfs-utils should decide about the default and that can be done either way. The difference is for people upgrading nfs-utils while keeping their old /etc/sysconfig/nfs. I've no problem with having an option to enable 4.1 (and I don't care much if it's -n or -P either). Should a distribution that want this option enabled by default use an undocumented option? I'm not sure. I'd prefer it to be documented if that's the case. > > If I'd known we'd be enabling 4.1 by default in nfs-utils, I wouldn't > have been so happy about removing the 4.1 config option--how confident > are we that the 4.1 code to be in 2.6.30 has no security holes? The more it will be tested and used, the better my confidence will be. I don't think that disabling it by default will help us find any security holes before the code will be ready for prime time. Not without a full blown QA effort. Benny > > --b. > >> --- /etc/sysconfig/nfs.orig 2009-04-22 14:57:15.000000000 +0300 >> +++ /etc/sysconfig/nfs 2009-04-22 14:46:52.000000000 +0300 >> @@ -26,6 +26,8 @@ >> #RPCNFSDARGS="-N 2 -N 3" >> # Turn off v4 protocol support >> #RPCNFSDARGS="-N 4" >> +# Turn off v4.1 minorversion support >> +RPCNFSDARGS="-N 4.1" >> # Number of nfs server processes to be started. >> # The default is 8. >> #RPCNFSDCOUNT=8 >> >> The patches in this set are: >> [PATCH 1/3] utils/nfsd: add support for minorvers4 >> [PATCH 2/3] utils/nfsd: disable minorvers4 via command line >> [PATCH 3/3] utils/nfsd: enable nfs minorvers4 by default >> >> Benny -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
