[PATCH] rpcbind: Change prognum, versnum, minvers, and maxvers in progping to rpcprog_t and rpcvers_t from u_long

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2009-04-22 at 18:08 -0400, Chuck Lever wrote:
> I take that back.  Replacing u_long with rpcvers_t will work in both  
> cases.  glibc's CLNT_CONTROL expects a u_long here, but TI-RPC expects  
> an u_int32_t.  These match the typedef for rpcvers_t for each of these.
> 
> So, you have to make sure you are building with the headers that go  
> with your RPC library.  The headers in /usr/include/rpc go with glibc,  
> and the headers in /usr/include/tirpc/rpc go with libtirpc.

Ok, here's a patch that implements it that way. It works fine on PPC64.

This fixes a problem where "rpcinfo -T transport host prognum" fails on a PPC64
because CLNT_CONTROL expects the version number to be a 32 bit quantity. u_long
probably works fine on little endian machines, but won't work on big endian
machines.

Signed-off-by: Frank Filz <ffilzlnx@xxxxxxxxxx>
---
 src/rpcinfo.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/src/rpcinfo.c b/src/rpcinfo.c
index 0170f65..c9f51cf 100644
--- a/src/rpcinfo.c
+++ b/src/rpcinfo.c
@@ -1591,7 +1591,8 @@ progping (netid, argc, argv)
   CLIENT *client;
   struct timeval to;
   enum clnt_stat rpc_stat;
-  u_long prognum, versnum, minvers, maxvers;
+  rpcprog_t prognum;
+  rpcvers_t versnum, minvers, maxvers;
   struct rpc_err rpcerr;
   int failure = 0;
   struct netconfig *nconf;
-- 
1.5.2.2



--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux