On Thu, 2009-04-16 at 09:52 -0400, Chuck Lever wrote: > On Apr 16, 2009, at 1:17 AM, Suresh Jayaraman wrote: > > Trond Myklebust wrote: > >> On Wed, 2009-04-15 at 19:40 +0530, Suresh Jayaraman wrote: > >>> The recent posixacl fix(commit > >>> ae46141ff08f1965b17c531b571953c39ce8b9e2) > >>> seems to have introduced a bug that will lead to -EINVAL errors > >>> during > >>> normal setfacl operations on file or dir. This patch attempts to fix > >>> this. > >> > >> To start with, your len_in_head is in units of 32-bit _words_, > >> whereas > >> len, base, and req->rq_slen are in units of bytes. > >> > >> Then, 'len' is initialised to the length of the currently encoded > >> part > >> of the RPC header before subtracting 'len_in_head'. The resulting > >> number > > > > Doh, I got it wrong totally. Thanks for the explaination. > > > > On a side note, I think it would be nice to add little comments in xdr > > code to explain non-obvious pieces. > > As an aside, I think implementing this with xdr_streams might have > some clarity benefits. Possibly, but right now, I just want to merge the one-liner fix into 2.6.30-rc2 and 2.6.29-stable... Cheers Trond -- Trond Myklebust Linux NFS client maintainer NetApp Trond.Myklebust@xxxxxxxxxx www.netapp.com -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
