On Tue, Apr 07, 2009 at 04:30:19PM -0400, Jeff Layton wrote:
> On Tue, 07 Apr 2009 16:01:31 -0400
> Tom Talpey <tmtalpey@xxxxxxxxx> wrote:
> >
> > >
> > >I'd rather see these people just update their kernels so that this
> > >isn't needed...
> >
> > Agreed. Would it make sense to log a message when the default 2049
> > is used? At least then, there's a chance an admin will know it's needed.
> >
>
> That's sounds reasonable. I've already asked Steve to commit the latest
> set, but we should be able to add something like this untested patch on
> top of it.
>
> If it looks ok, I'll test it out and officially resend it...
>
> Thoughts?
Would it work to do this in mount?--do the mount, then check any new
info file in rpc_pipefs to see if there's a port field?
Then we could give the error to the user where it's actually useful (as
output from the mount command). And also maybe only bother with it when
port= was specified.
--b.
>
> ----------------[snip]--------------------
>
> >From 7ac66dd50eafec3db3c816203fc24b9b72ff1f36 Mon Sep 17 00:00:00 2001
> From: Jeff Layton <jlayton@xxxxxxxxxx>
> Date: Tue, 7 Apr 2009 16:27:13 -0400
> Subject: [PATCH] nfs-utils: log warning when gssd detects an older kernel that doesn't send port in upcall
>
> Older kernels don't send port information in the upcall. This could
> cause mounts to fail for mysterious reasons. Log a warning the first
> time that gssd encounters an upcall without any port information in it.
>
> Signed-off-by: Jeff Layton <jlayton@xxxxxxxxxx>
> ---
> utils/gssd/gssd_proc.c | 12 +++++++++++-
> 1 files changed, 11 insertions(+), 1 deletions(-)
>
> diff --git a/utils/gssd/gssd_proc.c b/utils/gssd/gssd_proc.c
> index 02239d2..90182b0 100644
> --- a/utils/gssd/gssd_proc.c
> +++ b/utils/gssd/gssd_proc.c
> @@ -99,6 +99,8 @@
> * and rescan the whole {pipefs_nfsdir} when this happens.
> */
>
> +static int warned_on_port_field;
> +
> struct pollfd * pollarray;
>
> int pollsize; /* the size of pollaray (in pollfd's) */
> @@ -228,8 +230,16 @@ read_service_info(char *info_file_name, char **servicename, char **servername,
> }
>
> cb_port[0] = '\0';
> - if ((p = strstr(buf, "port")) != NULL)
> + if ((p = strstr(buf, "port")) != NULL) {
> sscanf(p, "port: %127s\n", cb_port);
> + } else if (!warned_on_port_field) {
> + warned_on_port_field = 1;
> + printerr(0, "WARNING: This kernel does not send port info "
> + "in the upcall. That support was added in "
> + "upstream kernel version 2.6.24. Using "
> + "non-standard ports may not work with this "
> + "kernel.\n");
> + }
>
> /* check service, program, and version */
> if(memcmp(service, "nfs", 3)) return -1;
> --
> 1.6.0.6
> _______________________________________________
> NFSv4 mailing list
> NFSv4@xxxxxxxxxxxxx
> http://linux-nfs.org/cgi-bin/mailman/listinfo/nfsv4
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
