On Sat, Apr 04, 2009 at 12:27:50PM -0400, Trond Myklebust wrote: > On Sat, 2009-04-04 at 12:19 -0400, Trond Myklebust wrote: > > On Sat, 2009-04-04 at 12:14 -0400, J. Bruce Fields wrote: > > > My regular connecthon tests are reporting bus errors on the "write/read > > > 30 MB file" on recent upstream kernels. I'm travelling and haven't had > > > a chance to do anything beyond kick off a dumb git-bisect, which pointed > > > the blame at the following commit. Any ideas? > > The following patch should fix it. > > Cheers > Trond > --------------------------------------------------------------- > >From b7a178f4fab331821b8cff384e1954e62aa63e52 Mon Sep 17 00:00:00 2001 > From: Trond Myklebust <Trond.Myklebust@xxxxxxxxxx> > Date: Sat, 4 Apr 2009 12:22:57 -0400 > Subject: [PATCH] NFS: Fix the return value in nfs_page_mkwrite() > > Commit c2ec175c39f62949438354f603f4aa170846aabb (mm: page_mkwrite change > prototype to match fault) exposed a bug in the NFS implementation of > page_mkwrite. We should be returning 0 on success... > > Signed-off-by: Trond Myklebust <Trond.Myklebust@xxxxxxxxxx> > --- > fs/nfs/file.c | 2 -- > 1 files changed, 0 insertions(+), 2 deletions(-) > > diff --git a/fs/nfs/file.c b/fs/nfs/file.c > index 3523b89..5a97bcf 100644 > --- a/fs/nfs/file.c > +++ b/fs/nfs/file.c > @@ -516,8 +516,6 @@ static int nfs_vm_page_mkwrite(struct vm_area_struct *vma, struct vm_fault *vmf) > goto out_unlock; > > ret = nfs_updatepage(filp, page, 0, pagelen); > - if (ret == 0) > - ret = pagelen; > out_unlock: > unlock_page(page); > if (ret) Thanks, looks good to me. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
