On Apr. 03, 2009, 3:20 +0300, andros@xxxxxxxxxx wrote: > From: Andy Adamson <andros@xxxxxxxxxx> > > March 31 review comments. > squash into nfsd41: non-page DRC for solo sequence responses > > Signed-off-by: Andy Adamson <andros@xxxxxxxxxx> > --- > include/linux/nfsd/xdr4.h | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/include/linux/nfsd/xdr4.h b/include/linux/nfsd/xdr4.h > index 0352863..3514f00 100644 > --- a/include/linux/nfsd/xdr4.h > +++ b/include/linux/nfsd/xdr4.h > @@ -493,7 +493,7 @@ static inline int nfsd4_is_solo_sequence(struct nfsd4_compoundres *resp) > return args->opcnt == 1; > } > > -static inline u32 nfsd4_not_cached(struct nfsd4_compoundres *resp) > +static inline int nfsd4_not_cached(struct nfsd4_compoundres *resp) Here too, returning bool is more appropriate. Benny > { > return (resp->cstate.slot->sl_cache_entry.ce_cachethis == 0 || > nfsd4_is_solo_sequence(resp)); -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html