On Tue, 31 Mar 2009, Trond Myklebust wrote: > > Please pull from the "for-linus" branch of the repository at > > git pull git://git.linux-nfs.org/projects/trondmy/nfs-2.6.git for-linus I _really_ want fscache to come with way more Acked-by's etc. So no, I'm not going to pull this. I want a lot more than just Signed-off-by: David Howells <dhowells@xxxxxxxxxx> on the 100+ lines of changes to the VM. I want the VM people pinged and asked whether it's ok. And I also have a stupid trivial complaint: WTF is up with absolutely inane crap like this: > fs/cachefiles/cf-bind.c | 286 +++++++ > fs/cachefiles/cf-daemon.c | 754 ++++++++++++++++++ > fs/cachefiles/cf-interface.c | 449 +++++++++++ > fs/cachefiles/cf-internal.h | 360 +++++++++ > fs/cachefiles/cf-key.c | 159 ++++ > fs/cachefiles/cf-main.c | 106 +++ > fs/cachefiles/cf-namei.c | 772 +++++++++++++++++++ > fs/cachefiles/cf-proc.c | 134 ++++ > fs/cachefiles/cf-rdwr.c | 853 +++++++++++++++++++++ > fs/cachefiles/cf-security.c | 116 +++ > fs/cachefiles/cf-xattr.c | 291 +++++++ ... > fs/fscache/fsc-cache.c | 415 ++++++++++ > fs/fscache/fsc-cookie.c | 498 ++++++++++++ > fs/fscache/fsc-fsdef.c | 144 ++++ > fs/fscache/fsc-histogram.c | 109 +++ > fs/fscache/fsc-internal.h | 380 +++++++++ > fs/fscache/fsc-main.c | 124 +++ > fs/fscache/fsc-netfs.c | 103 +++ > fs/fscache/fsc-object.c | 810 +++++++++++++++++++ > fs/fscache/fsc-operation.c | 459 +++++++++++ > fs/fscache/fsc-page.c | 771 +++++++++++++++++++ > fs/fscache/fsc-proc.c | 68 ++ > fs/fscache/fsc-stats.c | 212 +++++ What the hell is that "cf-" and "fsc-" prefix? We don't do single-level naming crud. It's already in a directory hierarchy, why the _hell_ does it then add some idiotic extra prefix that is just a (very inferior) copy of that hierarchy? If you want to write "fscache", write it out. Don't do "fsc". And do it as a directory. But then even an idiot would see that calling it fs/fscache/fscache/proc.c is a bit redundant. So why do you call it fs/fscache/fsc-proc.c? Gaah. Naming is a bid deal for me, and the above is just crap. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
