On Tue, 2009-03-03 at 16:57 -0700, Benny Halevy wrote: > need to take into account the getattr reply. > > Signed-off-by: Benny Halevy <bhalevy@xxxxxxxxxxx> > --- > fs/nfs/nfs4xdr.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/fs/nfs/nfs4xdr.c b/fs/nfs/nfs4xdr.c > index b60dc56..0e01660 100644 > --- a/fs/nfs/nfs4xdr.c > +++ b/fs/nfs/nfs4xdr.c > @@ -239,7 +239,7 @@ static int nfs4_stat_to_errno(int); > #define encode_fs_locations_maxsz \ > (encode_getattr_maxsz) > #define decode_fs_locations_maxsz \ > - (0) > + (decode_getattr_maxsz) This is a bit excessive. If you look at xdr_enc_fs_locations, you'll see that this just needs to decode the OP_GETATTR + status. All the data goes into the page. > #define NFS4_enc_compound_sz (1024) /* XXX: large enough? */ > #define NFS4_dec_compound_sz (1024) /* XXX: large enough? */ > #define NFS4_enc_read_sz (compound_encode_hdr_maxsz + \ > -- > 1.6.1.3 > > > -- Trond Myklebust Linux NFS client maintainer NetApp Trond.Myklebust@xxxxxxxxxx www.netapp.com -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
