On Mar. 28, 2009, 4:17 +0300, "J. Bruce Fields" <bfields@xxxxxxxxxxxx> wrote: > On Fri, Mar 27, 2009 at 05:58:45AM +0300, Benny Halevy wrote: >> Hi Bruce, >> >> Here's the latest server patches implementing the NFSv4.1 >> Sessions features. >> >> This patchset is based over your for-2.6.30 branch >> and is also available from >> git://linux-nfs.org/~bhalevy/linux-pnfs.git nfsd41-for-2.6.30 > > I ran the v4.0 pynfs on that branch and got some new failures: > > ACC3 st_access.testNoFh : FAILURE > value=10064 not in enum nfsstat4 > CLOSE7 st_close.testNoCfh : FAILURE > value=10064 not in enum nfsstat4 > CMT3 st_commit.testNoFh : FAILURE > value=10064 not in enum nfsstat4 > CR8 st_create.testNoFh : FAILURE > value=10064 not in enum nfsstat4 > > Looks like NFS4ERR_SEQUENCE_POS is leaking out to nfsv4 code for some > reason? Right, we checked ALLOWED_AS_FIRST_OP for minorversion 0 too. > > (Some similar results omitted.) > > Also there's a bunch of stuff like this: > > NVF1a st_nverify.testMandLink : FAILURE > NVerifying mandatory attributes against getattr should > return NFS4ERR_SAME, instead got NFS4_OK > NVF1d st_nverify.testMandDir : FAILURE > NVerifying mandatory attributes against getattr should > return NFS4ERR_SAME, instead got NFS4_OK > > Probably the expansion of the attribute bitmask is exposing some > preexisting bug in the 4.0 code, but let's try to figure out how to fix > that. A change to nfsd4_encode_fattr to encode bitmaps of variable length (rather than 2) broke _nfsd4_verify. > > I haven't investigated either of these any closer yet. > > --b. The following two patches fix these regressions: [PATCH 1/2] SQUASHME: nfsd41: do not verify nfserr_sequence_pos for minorversion 0 [PATCH 2/2] nfsd: dynamically skip encoded fattr bitmap in _nfsd4_verify Benny -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
