On Mar 26, 2009, at 4:58 AM, Greg Banks wrote:
Chuck Lever wrote:
Our port of rpcbind (from Sun) assumes this string contains a numeric
UID value, not alphabetical or symbolic characters, but checks this
value only for AF_LOCAL RPCB_SET or RPCB_UNSET requests. In all
other
cases, rpcbind ignores the contents of the r_owner string.
Not that this makes the slightest difference to the usefulness of the
patch, but it sounds like pretty strange behaviour for an rpcbind
server
to be using an incoming r_owner value off the wire under any
circumstances.
It's ignored for wire requests. r_owner is used only for AF_LOCAL
requests (ie a local file socket) where the kernel can guarantee the
owner.
The reference user space implementation of rpcb_set(3) uses a numeric
UID for all SET/UNSET requests (even via the network) and an empty
string for all other requests. We emulate that behavior here to
maintain bug-for-bug compatibility.
Fair enough.
Reviewed-by: Greg Banks <gnb@xxxxxxx>
Thanks.
--
Chuck Lever
chuck[dot]lever[at]oracle[dot]com
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
