On Mar 24, 2009, at 1:36 PM, Steve Dickson wrote:
Chuck Lever wrote:
On Mar 24, 2009, at 12:56 PM, Steve Dickson wrote:
Chuck Lever wrote:
I've actually already addressed all the cases you found under
utils/statd/... my re-writes replace both nsm_log() and note() with
calls to xlog(), and add return code checking to the write(2)
calls.
Sorry about that... but I already did the commit... since I wanted
to
get some testing asap.. so go head and send me the parts I broke
and I will do the forward port...
This is all only in my tree, and I haven't finished it yet, so I will
have to do the fix-ups myself.
Again, sorry about that..
Also, note that you can use the "%m" format specifier to generate
the
same string you get from strerror(errno).
Yeah.. I knew that... but I thought there some memory corruption
or service denial issue with using "%m" so I've always stuck
with '%d (%s)'.
I use %m routinely. What exactly are these issues?
It was a while ago... but I seem to remember there as an issue
with one of the daemons using '%m'.. I want to say a buffer overflow
but I just don't remember... It was probably some funky way '%m'
was being used...since I sure the normal every day use of '%m"
is fine...
I'm not a security expert, but I can't see how that could be a problem
for generating log messages (especially any message that precedes a
daemon's exit). I'd like to continue using "%m" with xlog() in my own
patches for the time being. Is that OK with you?
--
Chuck Lever
chuck[dot]lever[at]oracle[dot]com
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
