On Tue, 2009-03-17 at 08:15 -0400, Steve Dickson wrote: > Thanks Greg for taking a look... > > Greg Banks wrote: > > Kevin Constantine wrote: > > > > Maybe you can smooth out this difference, and make the code simpler and > > cleaner, by making the output always be exactly two columns, one for the > > label and one for the value. Then your earlier quoted example would be > > something like ... > > nfs v3 server readdir: 0 > > nfs v3 server readdirplus: 0 > > nfs v3 server fsstat: 0 > > nfs v3 server fsinfo: 0 > > nfs v3 server pathconf: 0 > > nfs v3 server commit: 0 > Finally, does it really make sense to show a stats with zero occurrences? > Why not just show what has happen instead of including what has not happen? I've done some playing with nfsstat and one thing I added was a -q (--quick) option that suppressed zero entries. It does make it a lot easier to look at stats when you only have to look at the interesting data. Frank -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
