On Mon, Mar 16, 2009 at 09:52:43AM +1100, James Morris wrote: > I think it's clearer and cleaner to convert all of the ops over to the > generic API, rather than, say, leaving in #ifdefs and similar code just > for listxattr. > > Also, this is part of preparation for adding other xattr handlers to the > NFS client code. The current xattr functions assume that ACLs are the > only types attributes being managed, and the generic handler code for > listxattr is necessary to manage others. > > If it's not acceptable as-is, I'll just batch it up with the rest of the > changes later. Honestly I think the "generic" listxattr implementation doesn't buy us anything as it just calls all handlers in a loop. But I'm not going to NACK the patch for that, I have some greater plans in that area, it just means touching one more place once the day comes. And the work to deal with list is more then offset by having get/set use the generic helpers :) -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
