On Tue, Mar 03, 2009 at 05:33:10PM -0500, Chuck Lever wrote: > The RPC client returns -EPROTONOSUPPORT if there is a protocol version > mismatch (ie the remote RPC server doesn't support the RPC protocol > version sent by the client). > > Helpers for the svc_register() function return -EPROTONOSUPPORT if they > don't recognize the passed-in IPPROTO_ value. > > These are two entirely different failure modes. > > Have the helpers return -ENOPROTOOPT instead of -ENOPROTOOPT. This will ^^^^^^^^^^^ should be -EPROTONOSUPPORT? --b. > allow callers to determine more precisely what the underlying problem is, > and decide to report or recover appropriately. > > This patch is part of a series that addresses > http://bugzilla.kernel.org/show_bug.cgi?id=12256 > > Signed-off-by: Chuck Lever <chuck.lever@xxxxxxxxxx> > --- > > net/sunrpc/svc.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/net/sunrpc/svc.c b/net/sunrpc/svc.c > index 6cc3c62..c89f04e 100644 > --- a/net/sunrpc/svc.c > +++ b/net/sunrpc/svc.c > @@ -749,7 +749,7 @@ static int __svc_rpcb_register4(const u32 program, const u32 version, > netid = RPCBIND_NETID_TCP; > break; > default: > - return -EPROTONOSUPPORT; > + return -ENOPROTOOPT; > } > > return rpcb_v4_register(program, version, > @@ -785,7 +785,7 @@ static int __svc_rpcb_register6(const u32 program, const u32 version, > netid = RPCBIND_NETID_TCP6; > break; > default: > - return -EPROTONOSUPPORT; > + return -ENOPROTOOPT; > } > > return rpcb_v4_register(program, version, > -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
