In that case, maybe the unused test should be cleaned up to avoid
fooling any other administrators.
Shall I send along a patch removing the test in setclientid_confirm?
(Its also used in increment_seqid)
Ben
J. Bruce Fields wrote:
On Wed, Mar 04, 2009 at 02:30:10PM -0500, Trond Myklebust wrote:
On Wed, 2009-03-04 at 14:01 -0500, J. Bruce Fields wrote:
On Wed, Mar 04, 2009 at 01:42:30PM -0500, Benjamin Coddington wrote:
Fixes a test in nfs4_proc_setclientid_confirm() which allows the client
to retry an operation when the server returns NFS4ERR_RESOURCE, instead
of returning EREMOTEIO to the user.
I remember being confused as to whether NFS4ERR_RESOURCE is transitory
(hence worth being retried) or permanent (in which case retrying the
identical compound won't help). The latter might happen if, for
example, the particular sequence of compounds sent by the client was
just too long or complicated for the server to handle.
But rfc3530 doesn't explicitly limit NFS4ERR_RESOURCE to that case, and
it appears that other clients:
http://www.nfsv4.org/nfsv4-wg-archive-feb-03-feb-05/0747.html
retry. That discussion isn't conclusive, though. Hm, and there's
further discussion from Mike Eisler here:
http://www.nfsv4-editor.org/cgi-bin/roundup/nfsv4/file7/comp-res.txt
which suggests it was intended as a permanent error.
What was the specific case where you hit this?
He says it was in SETCLIENTID_CONFIRM.
AIX used to abuse the NFS4ERR_RESOURCE error in order to delay clients
while the server was doing some preparations for state recovery. They
argues that they couldn't use NFS4ERR_DELAY since it isn't listed as a
legal error for SETCLIENTID_CONFIRM in RFC3530,
Oh, good grief, I'd forgotten that story. OK!--b.
and so they picked
NFS4ERR_RESOURCE. That would be a server bug...
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
